Ticket Navigation

Ticket #3 (task)

Opened 3 years ago

Last modified 2 years ago

Get behaviour of content and replace defined properly

Status: closed (fixed)

Reported by:	johnny	Assigned to:	johnny
Priority:	normal	Milestone:	4 - Finalization
Component:	component1	Version:
Severity:	normal	Keywords:
Cc:	johnny

Currently the behaviour/semantics of content and replace are rather vague. What happens with the existing contents is somewhat vague, and perhaps not really useful: for instance when a string is used for content for an element that has string contents and tags, the element's .text property will be set to the text, replacing the original text, and the children are left in tact. When an element is used instead of a string, the element is *appended* the the children array, rather than replacing it. Do we want to remove the children instead? Do we want this behaviour of adding rather than replacing to work for text too, and concatenate the original .text value with the new content? Do we want to set the tail of the last child instead of the text of the parent?

Change History

09/06/05 00:02:43: Modified by anonymous

cc set to johnny.

07/03/06 09:18:01: Modified by anonymous

severity changed from normal to blocker.
component changed from component1 to component2.
priority changed from normal to high.
version set to 2.0.
milestone deleted.
type changed from defect to enhancement.

private schools wilmington north carolina simple elegant wedding dress free nude african woman pic adult cam free live web linkin park background layout idea for school dance theme deicide halls of warship state of california birth record walden wg snuffy beginning of the end satellite space probe medication natural thyroid rogers cellular phone plan results betting exploited black teen trailer cosmetic surgery ontario point retail sale software store susana i m crazy love in you paxil premature ejaculation ferienwohnung bei dresden baby baby baby i love you lyrics free cream pie pussy almighty latin king queen nation uk top 50 single nitro video sexy movie guide little italy ohio cheap link paxil pharmacy.nismo.org college entrance essay free sample arizona state university gear ass bare pic flower delivery oakland mature hand job 12.5mg coreg various artist hard flash rocking man axxis pletnev mikhail variation 7 various artist hard delivering the goods live version judas priest commercial in nj property blow cute gallery job a career in advertising and marketing antivirus outlook 2003 new cell phone release 30 30hs420 hdtv kv monitor sony airline hawaii special language chat rooms house image satellite see attorney colorado divorce law dakota free guide south travel co compaq computer good spyware removal programs annunci e foto gay maturi maroon 5 this love sheet music

07/03/06 09:18:32: Modified by anonymous

severity changed from blocker to normal.
component changed from component2 to component1.
priority changed from high to highest.
version deleted.
milestone set to 2 - Cleanup and solidity.
type changed from enhancement to task.

07/05/06 13:17:19: Modified by johnny

priority changed from highest to high.
type changed from task to enhancement.
reporter changed from anonymous to johnny.

07/07/06 21:48:52: Modified by anonymous

severity changed from normal to major.
component changed from component1 to component2.
priority changed from high to low.
version set to 1.0.
milestone changed from 2 - Cleanup and solidity to 1 - Feature completeness.
type changed from enhancement to defect.

mac dvd burning software pc gaming monitor entry level computer job internet jobs international computer graphic adult web site design uk philadelphia web design business internet service provider canton ohio computer equipment repair company design indiana site web monitor is in power save mode activate using pc advanced port scanner 1350 hewlett packard printer enterprise project management software industrial design company construction payroll software computer refurbished toronto anti software spy ware computer electronics jobs computer graphic for movie digital dpp fp50 photo printer sony dvd authoring software review california internet marketing strategic no connection to internet available computer training education computer consultant data transfer free state and federal tax software free dvd decoding software celtic design jewelry silver sterling human resource management software program direct way satellite internet sauder heritage hill computer desk with hutch professional web site design arizona interior design in chicago buy keyboard music computer emachines personal free domain and free registration frequency louisiana police scanner computer download game sex internet phone india database enabled software web electronic keyboard music pin up girl tattoo design free game pda software oklahoma scanner frequency code arabic mehndi design free computer recycling lexmark x63 printer adaptive computer equipment consumer review software trading vantagepoint

07/07/06 21:48:57: Modified by anonymous

severity changed from major to normal.
component changed from component2 to component1.
priority changed from low to normal.
version deleted.
milestone changed from 1 - Feature completeness to 4 - Finalization.
type changed from defect to task.

07/17/06 15:28:07: Modified by johnny

Seems that t:content repeats the tail, which it shouldn't do. It should keep it in tact for the last item, and remove it for the rest.

Another issue I found is in processing the nodes: when there's a t:attr on a node that also has a t:content with list valued data, the t:attr should be resolved within the loop of the t:content, this to allow setting e.g. class for each item in the list. Another option would be to not remove the element at all, but really only its content (not sure about that one though).

09/17/06 13:28:23: Modified by johnny

status changed from new to assigned.

I just replaced lxml with a SAX based solution, which makes it all a lot less icky (no text and tail bits and such). I think this will make this issue void basically, but let's test some more IRL before I resolve it.

11/01/06 18:51:15: Modified by dghdfgh

11/02/06 19:01:18: Modified by ertDrjinklikeafish

11/02/06 20:23:21: Modified by ecoetrnstancasdfe

11/03/06 01:05:22: Modified by qwerhumphrieagd

01/16/07 12:17:04: Modified by johnny

status changed from assigned to closed.
resolution set to fixed.

I would say this is resolved after replacing lxml with nanosax. The behaviour is now simple and predictable. If there's a specific bit of behaviour that needs to be changed, let's use a new ticket.